mirror of
https://github.com/mgerb/react-starter
synced 2026-01-08 08:02:49 +00:00
favicon added to webpack build process
This commit is contained in:
@@ -14,9 +14,12 @@ A simplified starter project for react/typescript.
|
||||
http://localhost:8080
|
||||
|
||||
### TODO:
|
||||
Fix extract-text-webpack-plugin. Currently getting an error due to the webpack 4 upgrade.
|
||||
- Fix extract-text-webpack-plugin
|
||||
Currently getting an error due to the webpack 4 upgrade.
|
||||
Everything still seems fine though.
|
||||
|
||||
```
|
||||
Entrypoint undefined = extract-text-webpack-plugin-output-filename
|
||||
```
|
||||
|
||||
- use favicons-webpack-plugin when it's ready for Webpack 4
|
||||
- currently using [webapp-webpack-plugin](https://www.npmjs.com/package/webapp-webpack-plugin)
|
||||
|
||||
BIN
favicon.png
Normal file
BIN
favicon.png
Normal file
Binary file not shown.
|
After Width: | Height: | Size: 60 KiB |
937
package-lock.json
generated
937
package-lock.json
generated
File diff suppressed because it is too large
Load Diff
@@ -38,6 +38,7 @@
|
||||
"tslint": "^5.9.1",
|
||||
"tslint-config-airbnb": "^5.8.0",
|
||||
"typescript": "^2.7.2",
|
||||
"webapp-webpack-plugin": "^1.3.1",
|
||||
"webpack": "^4.1.1",
|
||||
"webpack-cli": "^2.0.12",
|
||||
"webpack-dev-server": "^3.1.1"
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
const CleanWebpackPlugin = require('clean-webpack-plugin');
|
||||
const ExtractTextPlugin = require('extract-text-webpack-plugin');
|
||||
const HtmlWebpackPlugin = require('html-webpack-plugin');
|
||||
const WebappWebpackPlugin = require('webapp-webpack-plugin');
|
||||
const path = require('path');
|
||||
const webpack = require('webpack');
|
||||
|
||||
@@ -72,5 +73,6 @@ module.exports = {
|
||||
template: './index.html',
|
||||
}),
|
||||
new webpack.HotModuleReplacementPlugin(),
|
||||
new WebappWebpackPlugin('./favicon.png'),
|
||||
],
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user