1
0
mirror of https://github.com/mgerb/react-starter synced 2026-01-09 08:32:48 +00:00

favicon added to webpack build process

This commit is contained in:
2018-03-22 21:16:01 -05:00
parent 85d8a4d76b
commit 3adf99fdc7
5 changed files with 945 additions and 2 deletions

View File

@@ -14,9 +14,12 @@ A simplified starter project for react/typescript.
http://localhost:8080 http://localhost:8080
### TODO: ### TODO:
Fix extract-text-webpack-plugin. Currently getting an error due to the webpack 4 upgrade. - Fix extract-text-webpack-plugin
Currently getting an error due to the webpack 4 upgrade.
Everything still seems fine though. Everything still seems fine though.
``` ```
Entrypoint undefined = extract-text-webpack-plugin-output-filename Entrypoint undefined = extract-text-webpack-plugin-output-filename
``` ```
- use favicons-webpack-plugin when it's ready for Webpack 4
- currently using [webapp-webpack-plugin](https://www.npmjs.com/package/webapp-webpack-plugin)

BIN
favicon.png Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 60 KiB

937
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -38,6 +38,7 @@
"tslint": "^5.9.1", "tslint": "^5.9.1",
"tslint-config-airbnb": "^5.8.0", "tslint-config-airbnb": "^5.8.0",
"typescript": "^2.7.2", "typescript": "^2.7.2",
"webapp-webpack-plugin": "^1.3.1",
"webpack": "^4.1.1", "webpack": "^4.1.1",
"webpack-cli": "^2.0.12", "webpack-cli": "^2.0.12",
"webpack-dev-server": "^3.1.1" "webpack-dev-server": "^3.1.1"

View File

@@ -1,6 +1,7 @@
const CleanWebpackPlugin = require('clean-webpack-plugin'); const CleanWebpackPlugin = require('clean-webpack-plugin');
const ExtractTextPlugin = require('extract-text-webpack-plugin'); const ExtractTextPlugin = require('extract-text-webpack-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin'); const HtmlWebpackPlugin = require('html-webpack-plugin');
const WebappWebpackPlugin = require('webapp-webpack-plugin');
const path = require('path'); const path = require('path');
const webpack = require('webpack'); const webpack = require('webpack');
@@ -72,5 +73,6 @@ module.exports = {
template: './index.html', template: './index.html',
}), }),
new webpack.HotModuleReplacementPlugin(), new webpack.HotModuleReplacementPlugin(),
new WebappWebpackPlugin('./favicon.png'),
], ],
}; };